Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158)

Issue 13696043: cmd/jujud: avoid using allFatal

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rog
Modified:
10 years, 6 months ago
Reviewers:
dimitern, fwereade, mp+185445
Visibility:
Public.

Description

cmd/jujud: avoid using allFatal This is a backport of the https://code.launchpad.net/~rogpeppe/juju-core/384-avoid-allfatal/+merge/184743 now proposed for 1.14, with selected other patches from other revisions to make it compile. https://code.launchpad.net/~rogpeppe/juju-core/391-1.14-avoid-allFatal/+merge/185445 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: avoid using allFatal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -65 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/agent.go View 1 chunk +21 lines, -0 lines 0 comments Download
M cmd/jujud/agent_test.go View 2 chunks +66 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 6 chunks +14 lines, -8 lines 0 comments Download
M cmd/jujud/machine_test.go View 5 chunks +6 lines, -6 lines 0 comments Download
M cmd/jujud/unit.go View 2 chunks +2 lines, -2 lines 0 comments Download
M juju/testing/conn.go View 9 chunks +48 lines, -36 lines 0 comments Download
M state/api/apiclient.go View 2 chunks +5 lines, -4 lines 0 comments Download
M state/apiserver/pinger_test.go View 2 chunks +12 lines, -0 lines 0 comments Download
M state/state.go View 1 chunk +6 lines, -0 lines 0 comments Download
M state/state_test.go View 1 chunk +6 lines, -0 lines 0 comments Download
A testing/checkers/set.go View 1 chunk +35 lines, -0 lines 0 comments Download
A testing/checkers/set_test.go View 1 chunk +54 lines, -0 lines 0 comments Download
M testing/mgo.go View 3 chunks +38 lines, -9 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 6 months ago (2013-09-13 09:27:38 UTC) #1
dimitern
LGTM
10 years, 6 months ago (2013-09-13 09:34:39 UTC) #2
fwereade
10 years, 6 months ago (2013-09-13 09:51:10 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b