Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(272)

Issue 13689043: code review 13689043: text/template/parse: mostly roll back the error detecti... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by r
Modified:
11 years, 8 months ago
Reviewers:
dsymonds, rsc
CC:
golang-dev, dsymonds, rsc
Visibility:
Public.

Description

text/template/parse: mostly roll back the error detection for unmatched right delimiters It's too late to change this behavior: it breaks templates with minimized JavaScript. Makes me sad because this common error can never be caught: "{foo}}". Three cheers for compatibility. (Leave in a fix to a broken test.)

Patch Set 1 #

Patch Set 2 : diff -r 290bc6eaa85f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/pkg/text/template/parse/lex.go View 1 chunk +0 lines, -4 lines 0 comments Download
M src/pkg/text/template/parse/lex_test.go View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 8 months ago (2013-09-13 01:53:02 UTC) #1
dsymonds
LGTM
11 years, 8 months ago (2013-09-13 01:55:28 UTC) #2
rsc
LGTM but add a test for the behavior we're preserving
11 years, 8 months ago (2013-09-13 01:56:54 UTC) #3
r
11 years, 8 months ago (2013-09-13 02:44:54 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=f0bc68f983b9 ***

text/template/parse: mostly roll back the error detection for unmatched right
delimiters
It's too late to change this behavior: it breaks templates with minimized
JavaScript.

Makes me sad because this common error can never be caught: "{foo}}".
Three cheers for compatibility.

(Leave in a fix to a broken test.)

R=golang-dev, dsymonds, rsc
CC=golang-dev
https://codereview.appspot.com/13689043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b