Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5218)

Issue 13684043: Moves the expose toggle to the inspector overview

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by jeff.pihach
Modified:
10 years, 7 months ago
Reviewers:
mp+185356, gary.poster
Visibility:
Public.

Description

Moves the expose toggle to the inspector overview Shares styling and markup for a consistent UI across the different viewlets. Also hooked up to the databinding engine. https://code.launchpad.net/~hatch/juju-gui/move-expose-service/+merge/185356 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moves the expose toggle to the inspector overview #

Patch Set 3 : Moves the expose toggle to the inspector overview #

Patch Set 4 : Moves the expose toggle to the inspector overview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -103 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/service-configuration.handlebars View 1 chunk +0 lines, -24 lines 0 comments Download
M app/templates/service-destroy.partial View 1 chunk +17 lines, -15 lines 0 comments Download
A app/templates/service-expose.partial View 1 chunk +15 lines, -0 lines 0 comments Download
M app/templates/serviceOverview.handlebars View 1 chunk +1 line, -0 lines 0 comments Download
M app/views/viewlets/service-config.js View 1 chunk +0 lines, -10 lines 0 comments Download
M app/views/viewlets/service-overview.js View 1 chunk +10 lines, -0 lines 0 comments Download
M lib/views/juju-inspector.less View 11 chunks +36 lines, -14 lines 0 comments Download
M test/test_inspector_overview.js View 3 chunks +34 lines, -1 line 0 comments Download
M test/test_inspector_settings.js View 4 chunks +5 lines, -39 lines 0 comments Download

Messages

Total messages: 6
jeff.pihach
Please take a look.
10 years, 7 months ago (2013-09-12 20:02:45 UTC) #1
jeff.pihach
Added review notes https://codereview.appspot.com/13684043/diff/1/app/templates/service-configuration.handlebars File app/templates/service-configuration.handlebars (left): https://codereview.appspot.com/13684043/diff/1/app/templates/service-configuration.handlebars#oldcode25 app/templates/service-configuration.handlebars:25: Moved from here to the overview ...
10 years, 7 months ago (2013-09-12 20:05:34 UTC) #2
gary.poster
code LGTM. doing qa
10 years, 7 months ago (2013-09-12 20:38:06 UTC) #3
gary.poster
On 2013/09/12 20:38:06, gary.poster wrote: > code LGTM. doing qa qa good on Chrome and ...
10 years, 7 months ago (2013-09-12 20:43:24 UTC) #4
jeff.pihach
Thanks for the review! IE QA OK
10 years, 7 months ago (2013-09-12 20:53:30 UTC) #5
jeff.pihach
10 years, 7 months ago (2013-09-13 14:16:48 UTC) #6
*** Submitted:

Moves the expose toggle to the inspector overview

Shares styling and markup for a consistent UI across
the different viewlets. Also hooked up to the databinding
engine.

R=
CC=
https://codereview.appspot.com/13684043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b