Issue 13677044: Hook up cancel buttons in the inspector

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13677044: Hook up cancel buttons in the inspector

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by gary.poster

Modified:
10 years, 7 months ago

Reviewers:
benjamin.saller, mp+185593

Visibility:
Public.

Description

Hook up cancel buttons in the inspector This branch simply hooks up the cancel buttons, which thanks to groundwork from Ben that I worked on in previous branches, is a one liner for each button. https://code.launchpad.net/~gary/juju-gui/enableInspectorCancel/+merge/185593 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Hook up cancel buttons in the inspector #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+211 lines, -1 line)			Patch
[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
app/views/environment.js	View	2 chunks	+4 lines, -1 line	0 comments	Download
app/views/inspector.js	View	2 chunks	+22 lines, -0 lines	0 comments	Download
test/test_inspector_constraints.js	View	1 chunk	+80 lines, -0 lines	0 comments	Download
test/test_inspector_settings.js	View	2 chunks	+103 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM QA Good in IE/Chrome Thanks for this. https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js File app/views/inspector.js (right): https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js#newcode837 app/views/inspector.js:837: this.viewletManager.bindingEngine.resetDOMToModel('config'); ...

10 years, 7 months ago (2013-09-13 20:37:20 UTC) #2

gary.poster

*** Submitted: Hook up cancel buttons in the inspector This branch simply hooks up the ...

10 years, 7 months ago (2013-09-13 20:47:47 UTC) #3

gary.poster

10 years, 7 months ago (2013-09-13 21:10:07 UTC) #4

On 2013/09/13 20:37:20, benjamin.saller wrote:
> LGTM
> QA Good in IE/Chrome
> 
> Thanks for this.
> 
> https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js
> File app/views/inspector.js (right):
> 
>
https://codereview.appspot.com/13677044/diff/1/app/views/inspector.js#newcode837
> app/views/inspector.js:837:
> this.viewletManager.bindingEngine.resetDOMToModel('config');
> This is how I hoped these would read, sorry it was so much work to make that
> actually true.

Thank you, Ben!

Expand All Messages | Collapse All Messages