Issue 136710044: code review 136710044: net/http: ensured that proxy errors are returned by Tra...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 136710044: code review 136710044: net/http: ensured that proxy errors are returned by Tra...

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by jmtuley

Modified:
9 years, 7 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-codereviews, jtuley_pivotal.io

Visibility:
Public.

Description

net/http: ensured that proxy errors are returned by Transport.RoundTrip. Fixes issue 8755.

Patch Set 2 : diff -r 367f0d62a03d1a14dd5b624ad68f86ca91c74419 https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r 367f0d62a03d1a14dd5b624ad68f86ca91c74419 https://code.google.com/p/go #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/net/http/transport.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/net/http/transport_test.go	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bradfitz

Have you submitted the CLA? https://codereview.appspot.com/136710044/diff/20001/src/net/http/transport_test.go File src/net/http/transport_test.go (right): https://codereview.appspot.com/136710044/diff/20001/src/net/http/transport_test.go#newcode1 src/net/http/transport_test.go:1: // Copyright 2011 The ...

9 years, 7 months ago (2014-09-17 20:04:18 UTC) #2

bradfitz

Fix the mangled line in transport_test.go too On Wed, Sep 17, 2014 at 4:09 PM, ...

9 years, 7 months ago (2014-09-17 20:50:32 UTC) #4

jmtuley

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com, jtuley@pivotal.io), I'd like you to review this change to https://code.google.com/p/go

9 years, 7 months ago (2014-09-18 00:53:21 UTC) #5

bradfitz

9 years, 7 months ago (2014-09-19 15:28:43 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=80d8c7b85a34 ***

net/http: ensured that proxy errors are returned by Transport.RoundTrip.

Fixes issue 8755.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews, jtuley
https://codereview.appspot.com/136710044

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages