code review 13670043: go/token: rename RemoveLine to MergeLine, improve docum...

go/token: rename RemoveLine to MergeLine, improve documentation

This is a follow-up to feedback from gri in
https://codereview.appspot.com/12837044/. Most of the wording
and naming improvements are lifted shamelessly from him.

[josharian, 2013-09-12 00:05:17]

Hello gri@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[josharian, 2013-09-12 00:08:00]

On 2013/09/12 00:05:17, josharian wrote:
> Hello mailto:gri@golang.org (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

I re-read and re-thought the logic in MergeLine again,
and I'm afraid I'm still convinced that it is correct as it stands.
I added some comments to explain the reasoning. And I'm
totally prepared to still be wrong. :)

At this point, feel free to go ahead and alter anything in this commit that
you like, if going back and forth with me is going to add overhead for you.

Cheers,
Josh

[gri, 2013-09-12 16:31:01]

LGTM.

Thanks.

[gri, 2013-09-12 16:31:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=5694c6095fc7 ***

go/token: rename RemoveLine to MergeLine, improve documentation

This is a follow-up to feedback from gri in
https://codereview.appspot.com/12837044/. Most of the wording
and naming improvements are lifted shamelessly from him.

R=gri
CC=golang-dev
https://codereview.appspot.com/13670043

Committer: Robert Griesemer <gri@golang.org>

[r, 2013-09-12 22:17:31]

Why is the name exported?

-rob

[gri, 2013-09-12 22:22:36]

On 2013/09/12 22:17:31, r wrote:
> Why is the name exported?
> 
> -rob

It's needed in package ast.