Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 13669045: Update Dart's CustomElement to latest Polymer tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by blois
Modified:
12 years, 10 months ago
Reviewers:
sigmund, John Messerly
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/CustomElements.git@master
Visibility:
Public.

Description

Merge remote-tracking branch 'upstream/master' Conflicts: src/CustomElements.js Merge pull request #61 from blois/enter_leave_view Updating enterView/leaveView callbacks to apply only to primary document... avoid using native implementation by default when document.webkitRegister is available. This is an outdated native implementation that is no longer spec compliant. Updating enterView/leaveView callbacks to apply only to primary document. Defer karma tests until after WebComponentsReady Match mocha test runner timings move MutationObserver definition to correct Firefox problem. - change entered/leftDocumentCallback to entered/leftViewCallback to match spec change - update tests and make pass with native blink implementation README: update lifecycle callback names improve error message Update CONTRIBUTING.md Polymer/polymer#273 test: remove karma-ios-launcher freshen tools test: refactor karma conf, add safari/ios Address same issue as PR 57. Android browser is not supported, but implemented fix since it's trivial. Remove CustomElements.watchAllShadows. Platform repo now overrides createShadowRoot and handles this automatically. Fixes issue #24. Also fixes CustomElements build. README: remove commmented section Addresses https://github.com/Polymer/docs/issues/138 tweak doc generation settings WCR must be async but use short async if available. upgrade SideTable fire WebComponentsReady event without delay README: add "lifecycle" so people can easily find this section. Fixup from feedback from pull request. Moving to master tools branch. Incorporating test from Blink with some tweaks to upgrade logic. Merge branch 'master' into blink_tests Wed Aug 21 17:33:49 PDT 2013 README: HTMLUnknownElement -> HTMLElement Docs: remove <element> from readme test: add karma-ie-launcher test: add karma-ie-launcher test: fix tests test: add missing file test: update grunt-karma throw exception if `name` argument to document.register contains no dash (+test) BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -398 lines) Patch
M .gitmodules View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M CONTRIBUTING.md View 1 chunk +1 line, -63 lines 0 comments Download
M README.md View 3 chunks +6 lines, -48 lines 0 comments Download
M conf/karma.conf.js View 1 2 1 chunk +12 lines, -71 lines 0 comments Download
M conf/mocha.conf.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M custom-elements.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gruntfile.js View 1 2 3 chunks +2 lines, -33 lines 0 comments Download
M package.json View 1 chunk +3 lines, -1 line 0 comments Download
M src/CustomElements.js View 9 chunks +90 lines, -68 lines 0 comments Download
M src/Observer.js View 1 2 15 chunks +72 lines, -39 lines 0 comments Download
M src/boot.js View 2 chunks +10 lines, -8 lines 0 comments Download
M src/sidetable.js View 2 chunks +9 lines, -4 lines 0 comments Download
M test/html/attributes.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/js/customElements.js View 1 2 7 chunks +94 lines, -51 lines 0 comments Download
A test/js/documentRegister.js View 1 chunk +209 lines, -0 lines 0 comments Download
A test/js/karma-defer-tests.js View 1 chunk +14 lines, -0 lines 0 comments Download
M test/js/upgrade.js View 1 chunk +1 line, -1 line 0 comments Download
M test/runner.html View 1 2 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2
blois
12 years, 11 months ago (2013-09-13 19:19:34 UTC) #1
sigmund
12 years, 11 months ago (2013-09-13 19:41:14 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b