Issue 13668048: code review 13668048: go.tools/ssa: fix ssa tests (fix build partly)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13668048: code review 13668048: go.tools/ssa: fix ssa tests (fix build partly) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by gri

Modified:
12 years, 6 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go.tools/ssa: fix ssa tests (fix build partly)

Patch Set 2 : diff -r 73ce43ee19e5 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 3 : diff -r 8fedb0591ff5 https://code.google.com/p/go.tools #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	ssa/testdata/objlookup.go	View	1	3 chunks	+4 lines, -1 line	0 comments	Download
	M	ssa/testdata/valueforexpr.go	View	1 2	3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 6 months ago (2013-09-18 18:08:13 UTC) #1

adonovan

LGTM Thanks. (In future, don't be afraid to bundle three such changes into one CL.) ...

12 years, 6 months ago (2013-09-18 18:37:53 UTC) #2

gri

*** Submitted as https://code.google.com/p/go/source/detail?r=614d9fe450b9&repo=tools *** go.tools/ssa: fix ssa tests (fix build partly) R=adonovan CC=golang-dev https://codereview.appspot.com/13668048 ...

12 years, 6 months ago (2013-09-18 18:39:58 UTC) #3

gri

12 years, 6 months ago (2013-09-18 18:39:58 UTC) #4

https://codereview.appspot.com/13668048/diff/3001/ssa/testdata/valueforexpr.go
File ssa/testdata/valueforexpr.go (right):

https://codereview.appspot.com/13668048/diff/3001/ssa/testdata/valueforexpr.g...
ssa/testdata/valueforexpr.go:5: // This file is the input to TestCanonicalPos in
source_test.go, which
On 2013/09/18 18:37:53, adonovan wrote:
> while you're here: TestValueForExpr

Done.

Expand All Messages | Collapse All Messages