Add Bundle model. No visible changes.

Add Bundle model.  No visible changes.

QA unnecessary as no moving parts are affected.

https://code.launchpad.net/~bac/juju-gui/bundle-model/+merge/187112

(do not edit description out of merge proposal)

[bac, 2013-09-23 21:43:38]

Please take a look.

[jeff.pihach, 2013-09-24 05:30:03]

LGTM, 

trivial comment

https://codereview.appspot.com/13660050/diff/1/app/models/bundle.js
File app/models/bundle.js (right):

https://codereview.appspot.com/13660050/diff/1/app/models/bundle.js#newcode54
app/models/bundle.js:54: this.set('id', this.get('id'));
this is setting it to itself so not needed

https://codereview.appspot.com/13660050/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/13660050/diff/1/test/test_model.js#newcode638
test/test_model.js:638: sampleData = Y.io('data/browsercharm.json', {sync:
true});
It would sure be great if we didn't have to make a get request on every test, we
should cache these.

[benji, 2013-09-24 12:49:02]

LGTM.

I just had one or two small comments.

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js
File test/test_model_bundle.js (right):

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js#newc...
test/test_model_bundle.js:34: bundle.get('id').should.equal('~bac/wiki/3/wiki');
[Benji's eyes begin to bleed.]

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js#newc...
test/test_model_bundle.js:39: describe('Bundle tests', function() {
Because of the stupid^W"unusual" test framework, this needs to be a noun phrase.
 Maybe "The bundle model".

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js#newc...
test/test_model_bundle.js:55: sampleData = Y.io('data/browserbundle.json',
{sync: true});
Whatever we do with the analogous setup in the charm model tests, we should do
the same here.

https://codereview.appspot.com/13660050/diff/1/test/utils.js
File test/utils.js (right):

https://codereview.appspot.com/13660050/diff/1/test/utils.js#newcode183
test/utils.js:183: @param {String} YAMLBundleURL File to import.
I love the smell of punctuation in the morning.

[bac, 2013-09-24 14:21:29]

*** Submitted:

Add Bundle model.  No visible changes.

QA unnecessary as no moving parts are affected.

R=jeff.pihach, benji
CC=
https://codereview.appspot.com/13660050

https://codereview.appspot.com/13660050/diff/1/app/models/bundle.js
File app/models/bundle.js (right):

https://codereview.appspot.com/13660050/diff/1/app/models/bundle.js#newcode54
app/models/bundle.js:54: this.set('id', this.get('id'));
On 2013/09/24 05:30:03, jeff.pihach wrote:
> this is setting it to itself so not needed

Done.

https://codereview.appspot.com/13660050/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/13660050/diff/1/test/test_model.js#newcode638
test/test_model.js:638: sampleData = Y.io('data/browsercharm.json', {sync:
true});
On 2013/09/24 05:30:03, jeff.pihach wrote:
> It would sure be great if we didn't have to make a get request on every test,
we
> should cache these.

Done.

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js
File test/test_model_bundle.js (right):

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js#newc...
test/test_model_bundle.js:34: bundle.get('id').should.equal('~bac/wiki/3/wiki');
On 2013/09/24 12:49:03, benji wrote:
> [Benji's eyes begin to bleed.]

Done.

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js#newc...
test/test_model_bundle.js:39: describe('Bundle tests', function() {
On 2013/09/24 12:49:03, benji wrote:
> Because of the stupid^W"unusual" test framework, this needs to be a noun
phrase.
>  Maybe "The bundle model".

Done.

https://codereview.appspot.com/13660050/diff/1/test/test_model_bundle.js#newc...
test/test_model_bundle.js:55: sampleData = Y.io('data/browserbundle.json',
{sync: true});
On 2013/09/24 12:49:03, benji wrote:
> Whatever we do with the analogous setup in the charm model tests, we should do
> the same here.

Done.

https://codereview.appspot.com/13660050/diff/1/test/utils.js
File test/utils.js (right):

https://codereview.appspot.com/13660050/diff/1/test/utils.js#newcode183
test/utils.js:183: @param {String} YAMLBundleURL File to import.
On 2013/09/24 12:49:03, benji wrote:
> I love the smell of punctuation in the morning.

Thanks linter!