Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(192)

Issue 13660046: code review 13660046: cmd/nm: put the -S flag in the usage message (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by r
Modified:
11 years, 7 months ago
Reviewers:
dsymonds
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

cmd/nm: put the -S flag in the usage message The -S flag reports symbol size, but is missing from the usage message.

Patch Set 1 #

Patch Set 2 : diff -r d1628698b8c8 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/nm/doc.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/nm/nm.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2013-09-16 05:59:20 UTC) #1
dsymonds
LGTM
11 years, 7 months ago (2013-09-16 06:03:14 UTC) #2
r
11 years, 7 months ago (2013-09-16 06:13:36 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=fb13de968200 ***

cmd/nm: put the -S flag in the usage message
The -S flag reports symbol size, but is missing from the usage message.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/13660046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b