Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 136570043: Update dependencies + other fixes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by frankban
Modified:
9 years, 7 months ago
Reviewers:
rharding, matthew.scott, mp+234469
Visibility:
Public.

Description

Update dependencies + other fixes. Update the GUI server dependencies: websocket-client, jujuclient, juju=deployer. Also included in the dependencies repo the new websocket-client requirements. Update selenium to the latest version (2.43.0) so that the functional tests pass on Firefox 32. The download cache has been updated accordingly. Fix how the suite detects if it is running on a local environment: do not use the environment name (unreliable), but retrieve the environment type instead. Fix the WebSocket client used when running functional tests to reflect changes in the new websocket-client. QA: run the test suite on precise and trusty: assuming your ec2 trusty environment is called ec2-trusty and your ec2 precise one is called ec2-precise, run the following: make test JUJU_ENV=ec2-trusty make test JUJU_ENV=ec2-precise As you already know, the functional tests take a while. https://code.launchpad.net/~frankban/charms/trusty/juju-gui/new-test-and-server-deps/+merge/234469 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update dependencies + other fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -33 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A deps/backports.ssl_match_hostname-3.4.0.2.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
D deps/juju-deployer-0.3.9.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/juju-deployer-0.4.0.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
D deps/jujuclient-0.17.5.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/jujuclient-0.18.4.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/six-1.8.0.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
D deps/websocket-client-0.12.0.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/websocket-client-0.18.0.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
M server-requirements.pip View 1 chunk +5 lines, -3 lines 0 comments Download
M test-requirements.pip View 1 chunk +1 line, -1 line 0 comments Download
M tests/20-functional.test View 3 chunks +17 lines, -13 lines 0 comments Download
M tests/helpers.py View 5 chunks +17 lines, -7 lines 0 comments Download
M tests/test_helpers.py View 5 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
9 years, 7 months ago (2014-09-12 13:48:01 UTC) #1
rharding
code looks good, starting up a QA/test run on trusty if the other reviewer could ...
9 years, 7 months ago (2014-09-12 14:13:06 UTC) #2
rharding
Ran 12 tests in 1809.282s QA good on trusty LGTM
9 years, 7 months ago (2014-09-12 14:56:39 UTC) #3
matthew.scott
LGTM, QA okay in precise.
9 years, 7 months ago (2014-09-12 16:48:37 UTC) #4
frankban
*** Submitted: Update dependencies + other fixes. Update the GUI server dependencies: websocket-client, jujuclient, juju=deployer. ...
9 years, 7 months ago (2014-09-12 17:07:10 UTC) #5
frankban
9 years, 7 months ago (2014-09-12 17:09:29 UTC) #6
Thank you both for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b