Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2006)

Issue 13655044: environs: clean up interfaces

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
natefinch, mp+185324
Visibility:
Public.

Description

environs: clean up interfaces Drive-by fix: "HasConfig" is not a great name for an interface; environs interfaces are conventionally held in environs/interface.go, and some of the GetMetadataSources comments wanted a bit more detail. https://code.launchpad.net/~rogpeppe/juju-core/389-rename-HasConfig/+merge/185324 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: clean up interfaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -30 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D environs/config/interface.go View 1 chunk +0 lines, -10 lines 0 comments Download
M environs/imagemetadata/urls.go View 1 chunk +10 lines, -6 lines 0 comments Download
M environs/interface.go View 3 chunks +15 lines, -3 lines 0 comments Download
M environs/tools/tools.go View 5 chunks +4 lines, -5 lines 0 comments Download
M environs/tools/urls.go View 1 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2
rog
Please take a look.
10 years, 7 months ago (2013-09-12 17:05:28 UTC) #1
natefinch
10 years, 7 months ago (2013-09-12 18:01:32 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b