code review 13653043: misc/cgo/test: test of issue 4339

misc/cgo/test: test of issue 4339

This is not quite what that issue reports,
because this does not involve a DLL.
But I wanted to make sure this much was working.

Update issue 4339

[rsc, 2013-09-10 20:29:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2013-09-10 20:33:00]

LGTM.

https://codereview.appspot.com/13653043/diff/1002/misc/cgo/test/issue4339.c
File misc/cgo/test/issue4339.c (right):

https://codereview.appspot.com/13653043/diff/1002/misc/cgo/test/issue4339.c#n...
misc/cgo/test/issue4339.c:7: //printf("impl\n");
do you want to leave this commented code?

[rsc, 2013-09-10 20:57:19]

yes, it's commented out so that it won't print during all.bash.
but it's useful to uncomment if you actually want to watch it run.

[minux1, 2013-09-11 02:30:25]

On 2013/09/10 20:57:19, rsc wrote:
> yes, it's commented out so that it won't print during all.bash.
> but it's useful to uncomment if you actually want to watch it run.
perhaps we can put the test to misc/cgo/testso?

[rsc, 2013-09-11 13:56:27]

On Tue, Sep 10, 2013 at 10:30 PM, <minux.ma@gmail.com> wrote:

> On 2013/09/10 20:57:19, rsc wrote:
>
>> yes, it's commented out so that it won't print during all.bash.
>> but it's useful to uncomment if you actually want to watch it run.
>>
> perhaps we can put the test to misc/cgo/testso?
>

i'm not sure what you mean. if you mean adding a second test in testso that
tests a shared-library version, that sounds fine. want to send a CL?

russ

[rsc, 2013-09-11 13:56:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=7727c1ad5ba5 ***

misc/cgo/test: test of issue 4339

This is not quite what that issue reports,
because this does not involve a DLL.
But I wanted to make sure this much was working.

Update issue 4339

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/13653043