Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(413)

Issue 136480043: code review 136480043: net: fix SetKeepAlivePeriod method of TCPConn (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by mikio
Modified:
5 years, 1 month ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

net: fix inconsistent behavior across platforms in SetKeepAlivePeriod The previous implementation used per-socket TCP keepalive options wrong. For example, it used another level socket option to control TCP and it didn't use TCP_KEEPINTVL option when possible. Fixes issue 8683. Fixes issue 8701. Update issue 8679

Patch Set 1 : diff -r ca2c8c76aed9059b73eac0a8986bf84e6f10f8b5 https://code.google.com/p/go #

Patch Set 2 : diff -r 769430bdffb74d3c36b14517b2b6972938b9428c https://code.google.com/p/go #

Patch Set 3 : diff -r 4057ec7e5d7411b67ebd364096cb010b533501e4 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -57 lines) Patch
M src/net/tcpsockopt_darwin.go View 1 2 chunks +7 lines, -5 lines 0 comments Download
M src/net/tcpsockopt_dragonfly.go View 1 1 chunk +5 lines, -8 lines 0 comments Download
R src/net/tcpsockopt_solaris.go View 1 1 chunk +0 lines, -27 lines 0 comments Download
M src/net/tcpsockopt_stub.go View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/net/tcpsockopt_unix.go View 1 2 chunks +3 lines, -7 lines 0 comments Download
M src/net/tcpsockopt_windows.go View 1 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 6
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years, 1 month ago (2014-09-10 14:34:41 UTC) #1
iant
This change seems to make the behaviour harder to understand and predict. Only experts are ...
5 years, 1 month ago (2014-09-10 18:30:21 UTC) #2
mikio
ptal On Thu, Sep 11, 2014 at 3:30 AM, <iant@golang.org> wrote: > This change seems ...
5 years, 1 month ago (2014-09-11 02:15:10 UTC) #3
iant
LGTM Thanks.
5 years, 1 month ago (2014-09-11 04:21:04 UTC) #4
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=0768bb1fd027 *** net: fix inconsistent behavior across platforms in SetKeepAlivePeriod The previous ...
5 years, 1 month ago (2014-09-11 08:57:09 UTC) #5
gobot
5 years, 1 month ago (2014-09-11 08:59:57 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-nocgo builder.
See http://build.golang.org/log/9df520d3a4ce79eb594376665658c433b4c3153f
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b