Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16971)

Issue 13645043: mgo version: before the timeout

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by jameinel
Modified:
10 years, 7 months ago
Reviewers:
mp+184772, gz
Visibility:
Public.

Description

mgo version: before the timeout Gustavo recently added support for causing the open socket connections to mongo to time out. This sounds great in theory, but in practice it is causing parts of the test suite to fail. On the bot I reverted to rev 240 (just before timeouts landed), and so this is just writing that down in the dependencies file. I have the feeling that eventually we'll want to support the timeouts and maybe just have code that retries if one that we are actively using times out? https://code.launchpad.net/~jameinel/juju-core/old-mgo/+merge/184772 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M dependencies.tsv View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
10 years, 7 months ago (2013-09-10 13:00:34 UTC) #1
gz
10 years, 7 months ago (2013-09-10 16:09:03 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b