Issue 13643044: code review 13643044: libmach: change three more BGET macro invocations back

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13643044: code review 13643044: libmach: change three more BGET macro invocations back (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rsc

Modified:
11 years, 8 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

libmach: change three more BGET macro invocations back Various compilers complain about the macro expansion not being used. I fixed a few yesterday. More today.

Patch Set 1 #

Patch Set 2 : diff -r 677a33edec74 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 677a33edec74 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 52c38a597fb0 https://code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	src/libmach/5obj.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/libmach/6obj.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libmach/8obj.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-09-10 15:53:22 UTC) #1

bradfitz

LGTM On Tue, Sep 10, 2013 at 8:53 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > ...

11 years, 8 months ago (2013-09-10 15:55:50 UTC) #2

LGTM



On Tue, Sep 10, 2013 at 8:53 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> libmach: change three more BGET macro invocations back
>
> Various compilers complain about the macro expansion not
> being used. I fixed a few yesterday. More today.
>
> Please review this at
https://codereview.appspot.**com/13643044/<https://codereview.appspot.com/136...
>
> Affected files (+4, -4 lines):
>   M src/libmach/5obj.c
>   M src/libmach/6obj.c
>   M src/libmach/8obj.c
>
>
> Index: src/libmach/5obj.c
> ==============================**==============================**=======
> --- a/src/libmach/5obj.c
> +++ b/src/libmach/5obj.c
> @@ -127,7 +127,7 @@
>                 break;
>         case D_REGREG:
>         case D_REGREG2:
> -               BGETC(bp);
> +               Bgetc(bp);
>                 break;
>         case D_CONST2:
>                 Bgetle4(bp); // fall through
> @@ -167,5 +167,5 @@
>  skip(Biobuf *bp, int n)
>  {
>         while (n-- > 0)
> -               BGETC(bp);
> +               Bgetc(bp);
>  }
> Index: src/libmach/6obj.c
> ==============================**==============================**=======
> --- a/src/libmach/6obj.c
> +++ b/src/libmach/6obj.c
> @@ -169,5 +169,5 @@
>  skip(Biobuf *bp, int n)
>  {
>         while (n-- > 0)
> -               BGETC(bp);
> +               Bgetc(bp);
>  }
> Index: src/libmach/8obj.c
> ==============================**==============================**=======
> --- a/src/libmach/8obj.c
> +++ b/src/libmach/8obj.c
> @@ -166,5 +166,5 @@
>  skip(Biobuf *bp, int n)
>  {
>         while (n-- > 0)
> -               BGETC(bp);
> +               Bgetc(bp);
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

rsc

11 years, 8 months ago (2013-09-10 16:24:46 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4131b84341bc ***

libmach: change three more BGET macro invocations back

Various compilers complain about the macro expansion not
being used. I fixed a few yesterday. More today.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13643044

Expand All Messages | Collapse All Messages