Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(906)

Issue 13641043: Allow identifiers or scheme expressions evaluating to music after \with (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
janek, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow identifiers or scheme expressions evaluating to music after \with This permits writing \with \voiceOne instead of \with { \voiceOne } which is mostly handy in the context of music/scheme function arguments.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M lily/parser.yy View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4
lemzwerg
LGTM.
10 years, 7 months ago (2013-09-10 10:28:06 UTC) #1
janek
As usual with my reviews: i definitely like the results, but i cannot say much ...
10 years, 7 months ago (2013-09-15 18:56:55 UTC) #2
dak
On 2013/09/15 18:56:55, janek wrote: > As usual with my reviews: i definitely like the ...
10 years, 7 months ago (2013-09-15 19:16:55 UTC) #3
dak
10 years, 7 months ago (2013-09-15 19:18:44 UTC) #4
On 2013/09/15 19:16:55, dak wrote:
> On 2013/09/15 18:56:55, janek wrote:
> > As usual with my reviews: i definitely like the results, but i cannot say
much
> > about the code.
> > 
> > thanks for another simplification!
> > Janek
> 
> It's not really a simplification: it's just moving one piece of code into
> another lexer class.  If it were up to me, I'd probably throw out INITIAL mode
> altogether, but when this was discussed previously, people felt that things
like
> .5\cm and 4.\cm were too important too give up (all of 0.5\cm, 4\cm and 4.0\cm
> would continue to work) in layout/paper definitions.
> 
> At least at the current point of time, output definitions are the _only_ place
> where the INITIAL lexer mode is still active.

Oops, disregard this comment.  I thought we were talking about a different
issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b