Issue 13629045: code review 13629045: misc/dist: add 'label' part of distro name, include blo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13629045: code review 13629045: misc/dist: add 'label' part of distro name, include blo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by adg

Modified:
11 years, 6 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

misc/dist: add 'label' part of distro name, include blog content This will allow us to cut binaries with names like: go1.2rc1.darwin-amd64-osx10.6.pkg go1.2rc1.darwin-amd64-osx10.8.pkg

Patch Set 1 #

Patch Set 2 : diff -r 92c2427826b9 https://code.google.com/p/go #

Patch Set 3 : diff -r b8680c5c8a9f https://code.google.com/p/go #

Patch Set 4 : diff -r b8680c5c8a9f https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -16 lines)			Patch
	M	misc/dist/bindist.go	View	1 2	12 chunks	+49 lines, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-09-19 06:44:25 UTC) #1

adg

11 years, 6 months ago (2013-09-19 06:51:38 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6c087c1f62c5 ***

misc/dist: add 'label' part of distro name, include blog content

This will allow us to cut binaries with names like:
        go1.2rc1.darwin-amd64-osx10.6.pkg
        go1.2rc1.darwin-amd64-osx10.8.pkg

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13629045

Expand All Messages | Collapse All Messages