Issue 13627048: Polish up the Charmwold API v2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13627048: Polish up the Charmwold API v2

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by benji

Modified:
10 years, 7 months ago

Reviewers:
mp+186119, gary.poster

Visibility:
Public.

Description

Polish up the Charmwold API v2 This branch is another step toward adding v3 support. The whole branch was too big so this branch was split out as an intermediary. https://code.launchpad.net/~benji/juju-gui/charmworld-api-2-tweaks/+merge/186119 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Polish up the Charmwold API v2 #

Patch Set 3 : Polish up the Charmwold API v2 #

Patch Set 4 : Polish up the Charmwold API v2 #

Patch Set 5 : Polish up the Charmwold API v2 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -38 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/charm.js	View	1 2	4 chunks	+14 lines, -9 lines	0 comments	Download
M	app/subapps/browser/views/view.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	app/widgets/charm-search.js	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	test/test_browser_search_widget.js	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	test/test_charm_store.js	View	1 2	12 chunks	+6 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benji

10 years, 7 months ago (2013-09-17 18:46:57 UTC) #3

*** Submitted:

Polish up the Charmwold API v2

This branch is another step toward adding v3 support.  The whole branch was
too big so this branch was split out as an intermediary.

R=gary.poster
CC=
https://codereview.appspot.com/13627048

Expand All Messages | Collapse All Messages