Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3248)

Issue 13624043: code review 13624043: cmd/gc: fix 'internal error: typename ideal bool' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/gc: fix 'internal error: typename ideal bool' Fixes issue 6298.

Patch Set 1 #

Patch Set 2 : diff -r 6df134a79c64 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 240922d4eb83 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/cmd/gc/walk.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
A test/fixedbugs/issue6298.go View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2013-09-09 16:00:15 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=ee14a38d17aa *** cmd/gc: fix 'internal error: typename ideal bool' Fixes issue 6298. ...
10 years, 6 months ago (2013-09-09 16:00:20 UTC) #2
ken3
10 years, 6 months ago (2013-09-10 15:55:26 UTC) #3
Message was sent while issue was closed.
On 2013/09/09 16:00:20, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=ee14a38d17aa ***
> 
> cmd/gc: fix 'internal error: typename ideal bool'
> 
> Fixes issue 6298.
> 
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/13624043

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b