Issue 13621043: Fix inspector constraints save button

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13621043: Fix inspector constraints save button

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by gary.poster

Modified:
10 years, 7 months ago

Reviewers:
benji, mp+184578

Visibility:
Public.

Description

Fix inspector constraints save button The inspector constraints tab had an odd bug: if you created a service and then looked at the inspector, opened the constraints tab, made a change, and clicked "Confirm," the button would save but then change the text to "Save Changes". After verifying with Luca the intended behavior was to have a "Confirm" text, this branch makes the button stay as is. https://code.launchpad.net/~gary/juju-gui/fixInspectorConstraintSave/+merge/184578 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix inspector constraints save button #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/inspector.js	View		1 chunk	+10 lines, -2 lines	0 comments	Download
M	test/test_inspector_constraints.js	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

10 years, 7 months ago (2013-09-09 14:11:17 UTC) #3

*** Submitted:

Fix inspector constraints save button

The inspector constraints tab had an odd bug: if you created a service and then
looked at the inspector, opened the constraints tab, made a change, and clicked
"Confirm," the button would save but then change the text to "Save Changes". 
After verifying with Luca the intended behavior was to have a "Confirm" text,
this branch makes the button stay as is.

R=benji
CC=
https://codereview.appspot.com/13621043

Expand All Messages | Collapse All Messages