Issue 136020043: code review 136020043: runtime: preallocate panic errors for index and slice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 136020043: code review 136020043: runtime: preallocate panic errors for index and slice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 6 months ago

Reviewers:
r, khr1

CC:
golang-codereviews, r, khr1, dvyukov, iant, khr

Visibility:
Public.

Description

runtime: preallocate panic errors for index and slice This avoids allocating at the panic sites.

Patch Set 1 #

Patch Set 2 : diff -r 7786bd1553ab00632e8ea85a78d640eb19c9d490 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7786bd1553ab00632e8ea85a78d640eb19c9d490 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 70fc2e0dcd39524bf0a596e464cba15f2938b13a https://code.google.com/p/go/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/pkg/runtime/panic.go	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r), I'd like you to review this change to ...

10 years, 6 months ago (2014-08-30 17:45:58 UTC) #1

khr1

LGTM. I have to do this for panicdivide as well. On Sat, Aug 30, 2014 ...

10 years, 6 months ago (2014-08-30 18:05:31 UTC) #3

rsc

10 years, 6 months ago (2014-08-30 18:18:38 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=a3136bee82dd ***

runtime: preallocate panic errors for index and slice

This avoids allocating at the panic sites.

LGTM=r, khr
R=golang-codereviews, r, khr
CC=dvyukov, golang-codereviews, iant, khr
https://codereview.appspot.com/136020043

Expand All Messages | Collapse All Messages