Issue 1360041: SHINDIG-1144 use correct json-rpc protocol response

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1360041: SHINDIG-1144 use correct json-rpc protocol response

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Paul Lindner

Modified:
13 years, 11 months ago

Reviewers:
dev, shindig.remailer

Visibility:
Public.

Description

This CL corrects the protocol response for json-rpc requests. It also adds a backwards compatible mode that returns json with both 'data' and 'result' keys.

Patch Set 1 #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -44 lines)			Patch
M	features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	features/src/main/javascript/features/osapi/jsonrpctransport.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/common/conf/shindig.properties	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java	View	5 chunks	+23 lines, -3 lines	0 comments	Download
M	java/common/src/test/java/org/apache/shindig/protocol/JsonRpcServletTest.java	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PipelineExecutor.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloader.java	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelineExecutorTest.java	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloaderTest.java	View	8 chunks	+9 lines, -9 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/render/DefaultServiceFetcherTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/PipelineDataGadgetRewriterTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Paul Lindner

would appreciate it if people could have a look at this.. It's a significant change...

13 years, 11 months ago (2010-05-27 23:00:28 UTC) #1

Paul Lindner

13 years, 11 months ago (2010-05-28 01:39:33 UTC) #3

This patch was committed with a bunch of others today.  I'm going to let it stay
in as-is, but would still be interested in any reviews.

Expand All Messages | Collapse All Messages