Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(492)

Issue 13592047: Factor out charmworld API helpers and rename

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by benji
Modified:
10 years, 7 months ago
Reviewers:
bac, rharding, mp+185591
Visibility:
Public.

Description

Factor out charmworld API helpers and rename These changes are part of the move to adding v3 of the charmworld API. https://code.launchpad.net/~benji/juju-gui/reorganize-charmworld-api-part-A/+merge/185591 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Factor out charmworld API helpers and rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -172 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 2 chunks +3 lines, -3 lines 0 comments Download
M app/models/charm.js View 3 chunks +6 lines, -5 lines 0 comments Download
M app/models/model-controller.js View 1 chunk +1 line, -1 line 0 comments Download
M app/store/charm.js View 6 chunks +106 lines, -64 lines 0 comments Download
M app/subapps/browser/browser.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/subapps/browser/views/charm.js View 1 chunk +1 line, -1 line 0 comments Download
M app/subapps/browser/views/charmresults.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/subapps/browser/views/view.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/topology/bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M docs/style-guide.rst View 1 chunk +6 lines, -6 lines 0 comments Download
M test/test_app.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_browser_app.js View 14 chunks +14 lines, -14 lines 0 comments Download
M test/test_browser_charm_details.js View 10 chunks +10 lines, -10 lines 0 comments Download
M test/test_browser_editorial.js View 8 chunks +8 lines, -8 lines 0 comments Download
M test/test_browser_search_view.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/test_browser_search_widget.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charm_panel.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charm_store.js View 13 chunks +61 lines, -34 lines 0 comments Download
M test/test_charm_view.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_conflict_ux.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_environment_view.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_ghost_inspector.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_charm.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_inspector_constraints.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_overview.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_settings.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test_model.js View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
benji
Please take a look.
10 years, 7 months ago (2013-09-13 20:07:08 UTC) #1
benji
Aside from the changes to app/store/charm.js, this branch is mostly mechanical renaming. https://codereview.appspot.com/13592047/diff/1/app/store/charm.js File app/store/charm.js ...
10 years, 7 months ago (2013-09-13 20:10:39 UTC) #2
bac
LGTM
10 years, 7 months ago (2013-09-13 20:50:03 UTC) #3
rharding
LGTM on the code. I'm not a huge fan of APIv2 as a name, but ...
10 years, 7 months ago (2013-09-13 21:52:42 UTC) #4
benji
On 2013/09/13 21:52:42, rharding wrote: > LGTM on the code. Thanks for the review. > ...
10 years, 7 months ago (2013-09-16 12:21:36 UTC) #5
benji
10 years, 7 months ago (2013-09-16 12:28:58 UTC) #6
*** Submitted:

Factor out charmworld API helpers and rename

These changes are part of the move to adding v3 of the charmworld API.

R=bac, rharding
CC=
https://codereview.appspot.com/13592047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b