Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(856)

Issue 13588043: Move the import field above the default toggle.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rharding
Modified:
10 years, 8 months ago
Reviewers:
mp+184263, matthew.scott
Visibility:
Public.

Description

Move the import field above the default toggle. - Move it above and enable it - Update test to deal with the fact that it's no longer disabled. https://code.launchpad.net/~rharding/juju-gui/move-config-file/+merge/184263 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Move the import field above the default toggle. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/ghost-config-viewlet.handlebars View 2 chunks +5 lines, -4 lines 0 comments Download
M test/test_ghost_inspector.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
rharding
Please take a look.
10 years, 8 months ago (2013-09-06 10:19:43 UTC) #1
matthew.scott
LGTM, IEQA okay
10 years, 8 months ago (2013-09-06 10:27:56 UTC) #2
rharding
10 years, 8 months ago (2013-09-06 10:35:51 UTC) #3
*** Submitted:

Move the import field above the default toggle.

- Move it above and enable it
- Update test to deal with the fact that it's no longer disabled.

R=matthew.scott
CC=
https://codereview.appspot.com/13588043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b