Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(320)

Issue 135840043: code review 135840043: go-tour: add analytics to old tour. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by francesc
Modified:
9 years, 6 months ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.2] go-tour: add analytics to old tour.

Patch Set 1 #

Patch Set 2 : diff -r 43b701ccd766ab33c675551c068f8db60a8b4ad3 https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M js/tour.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
francesc
Hello adg (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour
9 years, 6 months ago (2014-08-27 02:45:31 UTC) #1
adg
Please put "[release-branch.go1.2]" at the start of the commit message
9 years, 6 months ago (2014-08-27 02:46:13 UTC) #2
francesc
On 2014/08/27 02:46:13, adg wrote: > Please put "[release-branch.go1.2]" at the start of the commit ...
9 years, 6 months ago (2014-08-27 02:47:25 UTC) #3
adg
Sorry, it should be like this: [release-branch.go1.2] go-tour: add analytics to old tour.
9 years, 6 months ago (2014-08-27 02:48:06 UTC) #4
francesc
On 2014/08/27 02:48:06, adg wrote: > Sorry, it should be like this: > > [release-branch.go1.2] ...
9 years, 6 months ago (2014-08-27 02:48:39 UTC) #5
adg
LGTM :)
9 years, 6 months ago (2014-08-27 02:50:31 UTC) #6
francesc
9 years, 6 months ago (2014-08-27 02:51:04 UTC) #7
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=450551231b2d
***

[release-branch.go1.2] go-tour: add analytics to old tour.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/135840043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b