Sync relation menu with inspector open and close

Sync relation menu with inspector open and close

While the relation menu is going away soonish, if the plans are to be believed, meanwhile it is what we have.  This branch makes it so that when the inspector is first opened--after a ghost or when you click on a service--the relation menu appears.  Similarly, when you close the inspector, relation menus close.

It is still possible to hide the relation menu while the inspector is open.  If you begin to create a relation, the option will disappear; and if you click the canvas it will disappear.  These seem like pretty good interactions for me, given the fundamental oddity (to me) of having the relation menu and the inspector separate entities, at least given the current design.

https://code.launchpad.net/~gary/juju-gui/syncMenu/+merge/186107

(do not edit description out of merge proposal)

[gary.poster, 2013-09-17 17:13:01]

Please take a look.

[gary.poster, 2013-09-17 17:15:18]

Comments

https://codereview.appspot.com/13583044/diff/1/app/index.html
File app/index.html (left):

https://codereview.appspot.com/13583044/diff/1/app/index.html#oldcode44
app/index.html:44: <link rel="stylesheet"
href="/juju-ui/assets/juju-gui.css?reload=temporary">
Flyby.  We shouldn't need these any more, now that we've had the new charm
deployed for such a long time.

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js
File app/views/topology/service.js (left):

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:114: d.model.set('placeFromGhostPosition', false);
Moved below.

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:1338: toggleServiceMenu: function(box) {
We don't use this any more.

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:463: this.set('currentServiceClickAction',
'showServiceMenu');
Every time you click on a service, you will get the inspector and the service
menu.

[matthew.scott, 2013-09-17 17:33:49]

LGTM, QA okay

[gary.poster, 2013-09-17 17:46:16]

*** Submitted:

Sync relation menu with inspector open and close

While the relation menu is going away soonish, if the plans are to be believed,
meanwhile it is what we have.  This branch makes it so that when the inspector
is first opened--after a ghost or when you click on a service--the relation menu
appears.  Similarly, when you close the inspector, relation menus close.

It is still possible to hide the relation menu while the inspector is open.  If
you begin to create a relation, the option will disappear; and if you click the
canvas it will disappear.  These seem like pretty good interactions for me,
given the fundamental oddity (to me) of having the relation menu and the
inspector separate entities, at least given the current design.

R=matthew.scott
CC=
https://codereview.appspot.com/13583044