Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(547)

Issue 13578045: NR: explain that \type shouldn't be used in derived and midi contexts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by janek
Modified:
10 years, 7 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

NR: explain that \type shouldn't be used in derived and midi contexts

Patch Set 1 #

Patch Set 2 : duplicate because i had problems with git-cl #

Patch Set 3 : sorry, an unrelated patch got entangled previously #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 5
janek
duplicate because i had problems with git-cl
10 years, 7 months ago (2013-09-07 10:24:54 UTC) #1
janek
sorry, an unrelated patch got entangled previously
10 years, 7 months ago (2013-09-07 10:27:45 UTC) #2
janek
Please review. This could probably use some rewording, but i just wanted to write down ...
10 years, 7 months ago (2013-09-07 10:29:51 UTC) #3
dak
https://codereview.appspot.com/13578045/diff/4001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/13578045/diff/4001/Documentation/notation/changing-defaults.itely#newcode1194 Documentation/notation/changing-defaults.itely:1194: context. That puts out conflicting information since some lines ...
10 years, 7 months ago (2013-09-07 11:06:31 UTC) #4
janek
10 years, 7 months ago (2013-09-15 10:28:44 UTC) #5
On 2013/09/07 11:06:31, dak wrote:
>
https://codereview.appspot.com/13578045/diff/4001/Documentation/notation/chan...
> File Documentation/notation/changing-defaults.itely (right):
> 
>
https://codereview.appspot.com/13578045/diff/4001/Documentation/notation/chan...
> Documentation/notation/changing-defaults.itely:1194: context.
> That puts out conflicting information since some lines above it is stated
> "This should always be @code{Engraver_group}."
> 
> The section needs to make clear that it is written with the example of a
\layout
> definition in particular, establishing that there are multiple kinds of output
> definition, mentioning when something is only specific to \layout, and make
> clear that one needs to extend output definitions for all kinds of output one
> actually wants to generate.
> 
> But in this form, conflicting information is given in relation to a use case
> that is not the topic of this section, without putting it in context well
enough
> that people actually know what and why they are supposed to be doing.

This was superseded by https://codereview.appspot.com/13251045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b