Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(255)

Issue 135720043: Issue 471: Support Windows 8.1 applications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by peleyal
Modified:
4 years, 8 months ago
Reviewers:
class, jmcgrew
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 471: Support Windows 8.1 applications It looks a HUGE cl, but it's not. - WinRT was renamed to Windows - sln, csproj, pakcages.config were changed... TODO: 1. Is the text for supported platforms is OK? (Windows Phone 8 and 8.1) 2. Currently the Release tool doesn't build a WP project. Need to investigate and solve. Meantime I built the projects manually and then continue to run the flow (Create NuGet packages) 3. Test... MEANTIME, Windows 8.1 application works with the new Windows dll. What will we provide for Windows Phone 8.1???

Patch Set 1 #

Patch Set 2 : minor #

Total comments: 4

Patch Set 3 : Address Jeese's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -220 lines) Patch
M GoogleApisClient.sln View 1 2 5 chunks +56 lines, -56 lines 0 comments Download
M Src/GoogleApis.Auth.DotNet4/GoogleApis.Auth.DotNet4.csproj View 1 2 3 chunks +7 lines, -13 lines 0 comments Download
M Src/GoogleApis.Auth.DotNet4/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.Mvc4/GoogleApis.Auth.Mvc4.csproj View 1 2 3 chunks +7 lines, -13 lines 0 comments Download
M Src/GoogleApis.Auth.Mvc4/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.Tests/GoogleApis.Auth.Tests.csproj View 1 2 2 chunks +8 lines, -16 lines 0 comments Download
M Src/GoogleApis.Auth.Tests/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.WP/GoogleApis.Auth.WP.csproj View 1 2 3 chunks +10 lines, -14 lines 0 comments Download
M Src/GoogleApis.Auth.WP/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
R Src/GoogleApis.Auth.WinRT/packages.config View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/GoogleApis.Auth.Windows.csproj View 1 2 5 chunks +9 lines, -6 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeBroker.cs View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeWindowsInstalledApp.cs View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/OAuth2/GoogleWebAuthorizationBroker.cs View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.Auth.Windows/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
A Src/GoogleApis.Auth.Windows/packages.config View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/GoogleConsts.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Core/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.DotNet4/GoogleApis.DotNet4.csproj View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.DotNet4/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Tests/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.WP/GoogleApis.WP.csproj View 1 2 2 chunks +11 lines, -16 lines 0 comments Download
M Src/GoogleApis.WP/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
R Src/GoogleApis.WinRT/packages.config View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M Src/GoogleApis.Windows/Apis/Util/Store/StorageDataStore.cs View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M Src/GoogleApis.Windows/GoogleApis.Windows.csproj View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M Src/GoogleApis.Windows/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
A Src/GoogleApis.Windows/packages.config View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M Src/GoogleApis/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Tools/.nuget/NuGet.exe View 1 2 Binary file 0 comments Download
M Tools/Google.Apis.NuGet.Publisher/Template/.nuget/NuGet.exe View 1 2 Binary file 0 comments Download
M Tools/Google.Apis.NuGet.Publisher/Template/packages/Microsoft.Bcl.Build.1.0.14/tools/Microsoft.Bcl.Build.targets View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M Tools/Google.Apis.Release/App.config View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M Tools/Google.Apis.Release/Google.Apis.Release.csproj View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M Tools/Google.Apis.Release/Program.cs View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M Tools/Google.Apis.Release/Resources/Google.Apis.Auth.VERSION.nuspec View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M Tools/Google.Apis.Release/Resources/Google.Apis.Core.VERSION.nuspec View 1 2 1 chunk +11 lines, -12 lines 0 comments Download
M Tools/Google.Apis.Release/Resources/Google.Apis.VERSION.nuspec View 1 2 4 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 3
peleyal
jmcgrew, In continue to our talk, the Windows 8.1 app worked as expected... We are ...
4 years, 8 months ago (2014-08-24 03:06:50 UTC) #1
jmcgrew
Just some spelling nits. https://codereview.appspot.com/135720043/diff/10001/Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeWindowsInstalledApp.cs File Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeWindowsInstalledApp.cs (right): https://codereview.appspot.com/135720043/diff/10001/Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeWindowsInstalledApp.cs#newcode26 Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeWindowsInstalledApp.cs:26: /// OAuth 2.0 authorization code ...
4 years, 8 months ago (2014-08-25 19:06:50 UTC) #2
peleyal
4 years, 8 months ago (2014-08-28 21:08:17 UTC) #3
committing now

https://codereview.appspot.com/135720043/diff/10001/Src/GoogleApis.Auth.Windo...
File Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeWindowsInstalledApp.cs
(right):

https://codereview.appspot.com/135720043/diff/10001/Src/GoogleApis.Auth.Windo...
Src/GoogleApis.Auth.Windows/OAuth2/AuthorizationCodeWindowsInstalledApp.cs:26:
/// OAuth 2.0 authorization code flow for a Windows 8.1 installed applications
that persists end-user credentials.
On 2014/08/25 19:06:50, jmcgrew wrote:
> applications -> application

Done.

https://codereview.appspot.com/135720043/diff/10001/Tools/Google.Apis.Release...
File Tools/Google.Apis.Release/Program.cs (right):

https://codereview.appspot.com/135720043/diff/10001/Tools/Google.Apis.Release...
Tools/Google.Apis.Release/Program.cs:451: // Add Google.Apis.Winndows and
Google.Apis.Auth.Windows assemblies to a Windows folder.
On 2014/08/25 19:06:50, jmcgrew wrote:
> Winndows -> Windows

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b