Issue 13560043: Flag service as charm_changed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13560043: Flag service as charm_changed

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by matthew.scott

Modified:
10 years, 7 months ago

Reviewers:
rharding, mp+184109

Visibility:
Public.

Description

Flag service as charm_changed If a unit comes in for a service with a different charm url, then the service has had its charm set to something new. This will be true for both the user who set the charm on the service, and other uses watching on other GUI instances. https://code.launchpad.net/~makyo/juju-gui/upgrade-wait-for-delta/+merge/184109 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Flag service as charm_changed #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -2 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/assets/javascripts/Object.observe.poly.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	app/models/handlers.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/models/models.js	View	1	4 chunks	+33 lines, -0 lines	0 comments	Download
M	test/test_fakebackend.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/test_inspector_overview.js	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rharding

LGTM with the names camel cased, ignore my comments on .get/.set as you mentioned that ...

10 years, 7 months ago (2013-09-06 08:13:55 UTC) #2

matthew.scott

10 years, 7 months ago (2013-09-06 10:28:33 UTC) #3

*** Submitted:

Flag service as charm_changed

If a unit comes in for a service with a different charm url, then the service
has had its charm set to something new.  This will be true for both the user who
set the charm on the service, and other uses watching on other GUI instances.

R=rharding
CC=
https://codereview.appspot.com/13560043

Expand All Messages | Collapse All Messages