Issue 13553044: code review 13553044: net: don't error when marshalling nil IP addresses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13553044: code review 13553044: net: don't error when marshalling nil IP addresses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bradfitz

Modified:
11 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: don't error when marshalling nil IP addresses See https://code.google.com/p/go/issues/detail?id=6339#c3 Fixes Issue 6339

Patch Set 2 : diff -r f1754e7a7f5f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f1754e7a7f5f https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r b12952bbbbf7 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b12952bbbbf7 https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -12 lines)			Patch
	M	src/pkg/net/ip.go	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
	M	src/pkg/net/ip_test.go	View	1 2 3	2 chunks	+29 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2013-09-06 21:20:21 UTC) #1

rsc

https://codereview.appspot.com/13553044/diff/6001/src/pkg/net/ip_test.go File src/pkg/net/ip_test.go (left): https://codereview.appspot.com/13553044/diff/6001/src/pkg/net/ip_test.go#oldcode27 src/pkg/net/ip_test.go:27: {"", nil}, ParseIP should still reject "" I think. ...

11 years, 8 months ago (2013-09-06 22:10:32 UTC) #2

bradfitz

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 8 months ago (2013-09-06 22:20:44 UTC) #3

bradfitz

11 years, 8 months ago (2013-09-06 22:29:06 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=2a5486440b06 ***

net: don't error when marshalling nil IP addresses

See https://code.google.com/p/go/issues/detail?id=6339#c3

Fixes Issue 6339

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13553044

Expand All Messages | Collapse All Messages