Issue 13550046: add missing #include of <algorithm>, needed on VS2013 for std::min/max

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13550046: add missing #include of <algorithm>, needed on VS2013 for std::min/max (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by scottmg

Modified:
11 years, 11 months ago

Reviewers:
Shannon Woods

CC:
angleproject-review_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/angle.git@master

Visibility:
Public.

More Reviews

Description

add missing #include of <algorithm>, needed on VS2013 for std::min/max R=shannonwoods@chromium.org BUG=chromium:288948 Committed (not well): https://code.google.com/p/angleproject/source/detail?r=300b1eb5018651d2e68289a9dd234bbf906b3cc0

Patch Set 1 #

Patch Set 2 : . #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/libEGL/Surface.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Shannon Woods

On 2013/09/12 23:59:44, scottmg wrote: Is this all that's required to enable use of VS2013? ...

11 years, 11 months ago (2013-09-13 13:56:36 UTC) #2

scottmg

<algorithm> seems to be all that's required to get it to compile, but I guess ...

11 years, 11 months ago (2013-09-13 16:34:16 UTC) #3

Shannon Woods

11 years, 11 months ago (2013-09-17 19:38:49 UTC) #4

On 2013/09/13 16:34:16, scottmg wrote:
> <algorithm> seems to be all that's required to get it to compile, but I
> guess there must be runtime failures addressed by the other patch? I
> haven't gotten that far yet unfortunately.
> 
> 
> On Fri, Sep 13, 2013 at 6:56 AM, <mailto:shannonwoods@chromium.org> wrote:
> 
> > On 2013/09/12 23:59:44, scottmg wrote:
> >
> > Is this all that's required to enable use of VS2013? There is another
> > patch in review which had fallen behind on my priorities list that adds
> > both <algorithm> and newer mechanisms for version determination:
> >
>
https://codereview.appspot.**com/12665047/%3Chttps://codereview.appspot.com/1...>
> >
> >
>
https://codereview.appspot.**com/13550046/%3Chttps://codereview.appspot.com/1...>
> >

LGTM

Expand All Messages | Collapse All Messages