Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1165)

Issue 12665047: Fixes compilation with Visual Studio 2013.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by bfhben
Modified:
4 years, 2 months ago
Reviewers:
Shannon Woods, scottmg
CC:
angleproject-review_googlegroups.com
Base URL:
https://code.google.com/p/angleproject/@master
Visibility:
Public.

Description

Fixes compilation with Visual Studio 2013. GetVersion is deprecated and VerifyVersionInfo is the suggested replacement. VS2013 no longer includes std::min / std::max outside of <algorithm> and so this must be included. The project must be modified else on VS2013 the Windows.h header is not found, this appears to have no consequences outside of fixing VS2013 compilation.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M src/libEGL/Surface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/libEGL/libEGL.vcxproj View 1 chunk +0 lines, -1 line 0 comments Download
M src/libGLESv2/renderer/Renderer.h View 1 chunk +19 lines, -11 lines 3 comments Download
M src/libGLESv2/renderer/Renderer9.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
bfhben
4 years, 2 months ago (2013-08-25 21:47:39 UTC) #1
Shannon Woods
Support for an unreleased version of Visual Studio isn't super-high priority for ANGLE at the ...
4 years, 2 months ago (2013-08-26 16:49:37 UTC) #2
bfhben
On 2013/08/26 16:49:37, shannonwoods wrote: > Support for an unreleased version of Visual Studio isn't ...
4 years, 2 months ago (2013-08-26 16:53:54 UTC) #3
bfhben
On 2013/08/26 16:53:54, bfhben wrote: > On 2013/08/26 16:49:37, shannonwoods wrote: > > Support for ...
4 years, 2 months ago (2013-08-26 17:21:26 UTC) #4
scottmg
Any chance we could land either this or this simpler patch https://codereview.appspot.com/13550046/ to get compilation ...
4 years, 2 months ago (2013-09-17 19:24:16 UTC) #5
Shannon Woods
4 years, 2 months ago (2013-09-17 19:38:40 UTC) #6
On 2013/09/17 19:24:16, scottmg wrote:
> Any chance we could land either this or this simpler patch
> https://codereview.appspot.com/13550046/ to get compilation working?

The Windows 7 version still needs to be readded in this patch; the other one can
move forward in the meantime.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4