Classify templates into subdirectories depending on their usage.

Classify templates into subdirectories depending on their usage.

As the number of templates grew, it's becoming more daunting to figure out
what is what. This CL does:
- Remove the top tab Search and integrate it under Issues.
- Add a new tab Admin only shown to admin users.
- Move all issues related templates into templates/issues/.
- Move all non-top level Issues templates, i.e. templates meant to be imported by another template, into templates/issues/components/.
- Add README in the directories to explain what is what.

[M-A, 2013-09-05 14:27:19]

+ codereview-discuss in case someone has a strong opinion about this.

I think this CL is a net benefit. It makes the templates/ directory much more
maintainable and self-describing.

The main drawback is the demotion of Search under Issues but it just makes sense
and the {include} statements were pointing to that hierarchy.

Note that patchset #1 includes the diff of
https://codereview.appspot.com/13549043/, which is pending review at this
moment.

You can see it live at
https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com. It's fairly
possible I made a typo while grep'ing so it's possible I will have to do a
follow up CL. :)

[M-A, 2013-09-05 15:12:13]

Patchset #2 is ready to review.

[Roger Tawa, 2013-09-05 15:20:05]

https://codereview.appspot.com/13550043/diff/15001/codereview/views.py
File codereview/views.py (right):

https://codereview.appspot.com/13550043/diff/15001/codereview/views.py#newcod...
codereview/views.py:3377: request, 'issues/publish.html',
Put 'issues/publish.html' on next line?

https://codereview.appspot.com/13550043/diff/21001/templates/admin/base.html
File templates/admin/base.html (right):

https://codereview.appspot.com/13550043/diff/21001/templates/admin/base.html#...
templates/admin/base.html:7: {%endblock%}
Why is this needed since its the same as in ../base.html?

https://codereview.appspot.com/13550043/diff/21001/templates/issues/base.html
File templates/issues/base.html (right):

https://codereview.appspot.com/13550043/diff/21001/templates/issues/base.html...
templates/issues/base.html:10: {%endblock%}
Why is this needed since its the same as in ../base.html?

https://codereview.appspot.com/13550043/diff/21001/templates/issues/base.html...
templates/issues/base.html:31: <a href="{%url
codereview.views.search%}">Search</a>
Because you put this here, all templates that don't derive from this one no
longer have a search tab at top.  Just checking that this is what you actually
wanted.

https://codereview.appspot.com/13550043/diff/21001/templates/repos/base.html
File templates/repos/base.html (right):

https://codereview.appspot.com/13550043/diff/21001/templates/repos/base.html#...
templates/repos/base.html:9: {%endblock%}
Why is this needed since its the same as in ../base.html?

[M-A, 2013-09-05 15:33:57]

Thanks for the review, uploaded patchset #3 for the views.py alignment.

Guido, any opinion on the new layout of the files?

If the Search demotion to under Issues is a concern, I can hack it back in.

https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com/13550043/diff...
File codereview/views.py (right):

https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com/13550043/diff...
codereview/views.py:3377: request, 'issues/publish.html',
On 2013/09/05 15:20:06, Roger Tawa wrote:
> Put 'issues/publish.html' on next line?

Done.

https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com/13550043/diff...
File templates/admin/base.html (right):

https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com/13550043/diff...
templates/admin/base.html:7: {%endblock%}
On 2013/09/05 15:20:06, Roger Tawa wrote:
> Why is this needed since its the same as in ../base.html?

It's not *exactly* the same. The class="active" changes. It'd be nice to not
have to duplicate the list but I don't know how and this is how it was done
before.

https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com/13550043/diff...
File templates/issues/base.html (right):

https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com/13550043/diff...
templates/issues/base.html:10: {%endblock%}
On 2013/09/05 15:20:06, Roger Tawa wrote:
> Why is this needed since its the same as in ../base.html?

Almost exactly.

https://1160-c5f2c56ee799-tainted-dot-codereview-hr.appspot.com/13550043/diff...
templates/issues/base.html:31: <a href="{%url
codereview.views.search%}">Search</a>
On 2013/09/05 15:20:06, Roger Tawa wrote:
> Because you put this here, all templates that don't derive from this one no
> longer have a search tab at top.  Just checking that this is what you actually
> wanted.

Exact. Search is now a subcomponent of Issues. I expect this is the thing most
people could be the most unhappy about.

[M-A, 2013-09-06 14:20:55]

I understand the overwhelming excitement here. :)

A 'No' would do too if anyone thinks it's a bad idea, I just don't want to keep
this CL lingering for too long otherwise the merge conflicts will be painful.

[GvR, 2013-09-06 14:41:15]

On 2013/09/05 15:33:57, M-A wrote:
> Guido, any opinion on the new layout of the files?

Wow, we sure got a lot of templates. In general I am not a big fan of deep
hierarchies, but I really don't want to stand in the way of progress. :-)