Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 13547045: Deltas were causing canvas centering

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by matthew.scott
Modified:
10 years, 7 months ago
Reviewers:
mp+184146, benji
Visibility:
Public.

Description

Deltas were causing canvas centering Deltas were firing canvas resized events, this prevents centering on those events. https://code.launchpad.net/~makyo/juju-gui/ann-center/+merge/184146 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Deltas were causing canvas centering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/viewport.js View 1 1 chunk +8 lines, -1 line 0 comments Download
M test/test_viewport_module.js View 1 4 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 3
matthew.scott
Please take a look.
10 years, 7 months ago (2013-09-05 17:03:14 UTC) #1
benji
LGTM. https://codereview.appspot.com/13547045/diff/1/app/views/topology/viewport.js File app/views/topology/viewport.js (right): https://codereview.appspot.com/13547045/diff/1/app/views/topology/viewport.js#newcode97 app/views/topology/viewport.js:97: // if the size has actually changed (as ...
10 years, 7 months ago (2013-09-05 17:08:49 UTC) #2
matthew.scott
10 years, 7 months ago (2013-09-06 07:59:00 UTC) #3
*** Submitted:

Deltas were causing canvas centering

Deltas were firing canvas resized events, this prevents centering on those
events.

R=benji
CC=
https://codereview.appspot.com/13547045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b