code review 13546044: cmd/dist: don't print misleading warning when using GOR...

cmd/dist: don't print misleading warning when using GOROOT_FINAL

Fixes issue 5240.

[iant, 2013-09-04 23:57:27]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-09-05 00:00:08]

LGTM



On Wed, Sep 4, 2013 at 4:57 PM, <iant@golang.org> wrote:

> A small code review. Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/dist: don't print misleading warning when using GOROOT_FINAL
>
> Fixes issue 5240.
>
> Please review this at
https://codereview.appspot.**com/13546044/<https://codereview.appspot.com/135...
>
> Affected files +4, -1:
>   M src/cmd/dist/build.c
>
>
> Index: src/cmd/dist/build.c
> ==============================**==============================**=======
> --- a/src/cmd/dist/build.c
> +++ b/src/cmd/dist/build.c
> @@ -1660,7 +1660,10 @@
>         xprintf("Installed Go for %s/%s in %s\n", goos, goarch, goroot);
>         xprintf("Installed commands in %s\n", gobin);
>
> -       if(streq(gohostos, "plan9")) {
> +       if(!xsamefile(goroot_final, goroot)) {
> +               // If the files are to be moved, don't check that gobin
> +               // is on PATH; assume they know what they are doing.
> +       } else if(streq(gohostos, "plan9")) {
>                 // Check that gobin is bound before /bin.
>                 readfile(&b, "#c/pid");
>                 bsubst(&b, " ", "");
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[iant, 2013-09-05 00:02:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=11b2294dca61 ***

cmd/dist: don't print misleading warning when using GOROOT_FINAL

Fixes issue 5240.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13546044