Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 135360043: code review 135360043: ogle/program/server: allow adding and removing breakpoints (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by nigeltao
Modified:
7 years, 3 months ago
Reviewers:
r
CC:
r
Visibility:
Public.

Description

ogle/program/server: allow adding and removing breakpoints concurrently with waiting to hit an existing breakpoint.

Patch Set 1 #

Patch Set 2 : diff -r 0418a4e17396e2de2197a47cd4d6af67a54827d0 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 0418a4e17396e2de2197a47cd4d6af67a54827d0 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 0418a4e17396e2de2197a47cd4d6af67a54827d0 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -57 lines) Patch
M program/server/ptrace.go View 1 3 chunks +43 lines, -6 lines 0 comments Download
M program/server/server.go View 1 2 3 13 chunks +132 lines, -51 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 3 months ago (2014-09-03 08:26:14 UTC) #1
r
LGTM you've reinvented the Xfid structure in the acme code.
7 years, 3 months ago (2014-09-03 15:59:40 UTC) #2
nigeltao
7 years, 3 months ago (2014-09-05 01:27:41 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=983f81634c48 ***

ogle/program/server: allow adding and removing breakpoints
concurrently with waiting to hit an existing breakpoint.

LGTM=r
R=r
https://codereview.appspot.com/135360043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b