Post setCharm, get_charm

Post setCharm, get_charm

After setting a charm (upgrading or downgrading), fetch the version of the charm we just set to see if an ugprade is needed anymore.

https://code.launchpad.net/~makyo/juju-gui/upgrade-charm-reset-inspector/+merge/183900

(do not edit description out of merge proposal)

[matthew.scott, 2013-09-04 15:03:23]

Please take a look.

[matthew.scott, 2013-09-04 15:10:25]

Please take a look.

[benji, 2013-09-04 15:36:09]

Nice branch.  LGTM.

https://codereview.appspot.com/13527043/diff/4001/test/test_inspector_overvie...
File test/test_inspector_overview.js (right):

https://codereview.appspot.com/13527043/diff/4001/test/test_inspector_overvie...
test/test_inspector_overview.js:512: env.setCharm = function(serviceName,
upgradeTo, force, callback) {
If you felt froggy, now would be a good time to change the name "setCharm" to
"set_charm".

[benjamin.saller, 2013-09-04 15:53:32]

LGTM but I did have the one question below that might require a change.

https://codereview.appspot.com/13527043/diff/4001/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/13527043/diff/4001/app/views/inspector.js#newc...
app/views/inspector.js:926: service.set('upgrade_available', !!latestId);
You're trying to flip true/false here to force the event to trigger the
databinding update? I might be wrong but past lastestId 1 won't this always
result in the same value. 

some variant of 
service.set('upgrade_available', !service.get('upgrade_available'));

might be better.

If I misunderstood this though happy to leave as long as you tell me why.

[matthew.scott, 2013-09-04 15:55:15]

*** Submitted:

Post setCharm, get_charm

After setting a charm (upgrading or downgrading), fetch the version of the charm
we just set to see if an ugprade is needed anymore.

R=benji
CC=
https://codereview.appspot.com/13527043