code review 13523044: crypto/rand: make Read use io.ReadFull

crypto/rand: make Read use io.ReadFull

Fixes Issue 6084

[bradfitz, 2013-09-05 16:24:40]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-09-05 16:26:31]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-09-05 16:29:05]

https://codereview.appspot.com/13523044/diff/3002/src/pkg/crypto/rand/example...
File src/pkg/crypto/rand/example_test.go (right):

https://codereview.appspot.com/13523044/diff/3002/src/pkg/crypto/rand/example...
src/pkg/crypto/rand/example_test.go:19: if err != nil || n != c {
This should be

if err != nil {

There is no need to check n != c, just like the old example did not check it.

[bradfitz, 2013-09-05 16:30:33]

I know it's not necessary.  I was trying to make a point in the example
that you can rely on it being full.

But yeah, we don't want to encourage people to do that check.  Removed.




On Thu, Sep 5, 2013 at 9:29 AM, <rsc@golang.org> wrote:

>
> https://codereview.appspot.**com/13523044/diff/3002/src/**
>
pkg/crypto/rand/example_test.**go<https://codereview.appspot.com/13523044/diff/3002/src/pkg/crypto/rand/example_test.go>
> File src/pkg/crypto/rand/example_**test.go (right):
>
> https://codereview.appspot.**com/13523044/diff/3002/src/**
>
pkg/crypto/rand/example_test.**go#newcode19<https://codereview.appspot.com/13523044/diff/3002/src/pkg/crypto/rand/example_test.go#newcode19>
> src/pkg/crypto/rand/example_**test.go:19: if err != nil || n != c {
> This should be
>
> if err != nil {
>
> There is no need to check n != c, just like the old example did not
> check it.
>
>
https://codereview.appspot.**com/13523044/<https://codereview.appspot.com/135...
>

[bradfitz, 2013-09-05 16:30:49]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2013-09-06 01:10:41]

On 2013/09/05 16:30:49, bradfitz wrote:
> Hello mailto:golang-dev@googlegroups.com, mailto:rsc@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

LGTM.

[bradfitz, 2013-09-06 19:00:26]

*** Submitted as https://code.google.com/p/go/source/detail?r=1dcf19a19068 ***

crypto/rand: make Read use io.ReadFull

Fixes Issue 6084

R=golang-dev, rsc, dave
CC=golang-dev
https://codereview.appspot.com/13523044