code review 135230043: runtime: fix openbsd build

runtime: fix openbsd build

[mdempsky, 2014-08-30 03:05:58]

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com,
jsing@google.com),

I'd like you to review this change to
https://code.google.com/p/go

[mdempsky, 2014-08-30 03:15:34]

Tested that it builds on openbsd/386 again.

https://codereview.appspot.com/135230043/diff/50001/src/pkg/runtime/defs_open...
File src/pkg/runtime/defs_openbsd.go (right):

https://codereview.appspot.com/135230043/diff/50001/src/pkg/runtime/defs_open...
src/pkg/runtime/defs_openbsd.go:121: type Kevent C.struct_kevent
Hm, I just noticed that in revision 91378329bf67, rsc updated the generated
defs_GOOS_GOARCH.h headers for SigactionT and KeventT, but didn't update the
source defs_GOOS.go files.  Not sure whether I should go ahead and fix KeventT
here, or leave it for a more comprehensive fix to all of the files later?

[minux, 2014-08-30 03:29:52]

https://codereview.appspot.com/135230043/diff/50001/src/pkg/runtime/defs_open...
File src/pkg/runtime/defs_openbsd.go (right):

https://codereview.appspot.com/135230043/diff/50001/src/pkg/runtime/defs_open...
src/pkg/runtime/defs_openbsd.go:121: type Kevent C.struct_kevent
On 2014/08/30 03:15:34, mdempsky wrote:
> Hm, I just noticed that in revision 91378329bf67, rsc updated the generated
> defs_GOOS_GOARCH.h headers for SigactionT and KeventT, but didn't update the
> source defs_GOOS.go files.  Not sure whether I should go ahead and fix KeventT
> here, or leave it for a more comprehensive fix to all of the files later?
I think it should be updated.

[mdempsky, 2014-08-30 03:32:09]

https://codereview.appspot.com/135230043/diff/50001/src/pkg/runtime/defs_open...
File src/pkg/runtime/defs_openbsd.go (right):

https://codereview.appspot.com/135230043/diff/50001/src/pkg/runtime/defs_open...
src/pkg/runtime/defs_openbsd.go:121: type Kevent C.struct_kevent
On 2014/08/30 03:29:52, minux wrote:
> On 2014/08/30 03:15:34, mdempsky wrote:
> > Hm, I just noticed that in revision 91378329bf67, rsc updated the generated
> > defs_GOOS_GOARCH.h headers for SigactionT and KeventT, but didn't update the
> > source defs_GOOS.go files.  Not sure whether I should go ahead and fix
KeventT
> > here, or leave it for a more comprehensive fix to all of the files later?
> I think it should be updated.

Done.

[iant, 2014-08-30 03:51:06]

LGTM

[iant, 2014-08-30 03:51:36]

*** Submitted as https://code.google.com/p/go/source/detail?r=60812bad3769 ***

runtime: fix openbsd build

LGTM=iant
R=iant, minux
CC=golang-codereviews, jsing
https://codereview.appspot.com/135230043

Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-08-30 03:52:54]

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/667a97e961ca85bb900db5639a614ce8d1ff6a7f

[dave_cheney.net, 2014-08-30 03:56:04]

Yup, this is real, it's broken the API check for all platforms that
are not openbsd.

On Sat, Aug 30, 2014 at 1:52 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the windows-amd64-perf builder.
> See http://build.golang.org/log/667a97e961ca85bb900db5639a614ce8d1ff6a7f
>
>
> https://codereview.appspot.com/135230043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.