Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2092)

Issue 13520043: http.Client: support InsecureSkipVerify

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jameinel
Modified:
10 years, 8 months ago
Reviewers:
mue, mp+183844
Visibility:
Public.

Description

http.Client: support InsecureSkipVerify This adds a new API http.NewNonSSValidating which ends up passing InsecureSkipVerify: true all the way down the http stack. Because we were using the global stdlib net/http.DefaultClient to enable connection sharing, etc, we continue to cache the http.Client object. I only create the object once we actually need it, and we only use it for requests that also want to be "insecure". I'm open to suggestions if we want to name the API differently. We could also do it as a flag to New() but that is an API break (meaning juju-core stops building until we patch juju-core). So I felt this was a reasonable method. This is step 2 in my work to support ssl-hostname-verify:false for the Openstack provider. (bug #1202163) https://code.launchpad.net/~jameinel/goose/httpclient-ssl/+merge/183844 Requires: https://code.launchpad.net/~jameinel/goose/httpsuite-ssl/+merge/183838 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M http/client.go View 3 chunks +18 lines, -0 lines 0 comments Download
M http/client_test.go View 3 chunks +46 lines, -18 lines 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
10 years, 8 months ago (2013-09-04 10:44:34 UTC) #1
mue
10 years, 8 months ago (2013-09-04 10:51:12 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b