Issue 13515044: Prevent type-error on services in a line

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13515044: Prevent type-error on services in a line

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by matthew.scott

Modified:
10 years, 7 months ago

Reviewers:
mp+184124, jeff.pihach

Visibility:
Public.

Description

Prevent type-error on services in a line Services in a line cannot be passed to the hull() method if they are in a line (you can't transverse in a counterclockwise manner over a linear set of points), so safeHull just returns the vertices if that's the case. https://code.launchpad.net/~makyo/juju-gui/service-line/+merge/184124 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Prevent type-error on services in a line #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/utils.js	View	3 chunks	+20 lines, -7 lines	0 comments	Download
M	test/test_topology_utils.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

matthew.scott

10 years, 7 months ago (2013-09-05 15:11:28 UTC) #3

*** Submitted:

Prevent type-error on services in a line

Services in a line cannot be passed to the hull() method if they are in a line
(you can't transverse in a counterclockwise manner over a linear set of points),
so safeHull just returns the vertices if that's the case.

R=jeff.pihach
CC=
https://codereview.appspot.com/13515044

Expand All Messages | Collapse All Messages