Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(643)

Issue 13512052: code review 13512052: compress/gzip: add Reset method to Reader (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by kortschak
Modified:
6 years, 5 months ago
Reviewers:
rsc
CC:
golang-codereviews, bradfitz, rsc, gobot
Visibility:
Public.

Description

compress/gzip: add Reset method to Reader Fixes issue 6364.

Patch Set 1 #

Patch Set 2 : diff -r 09706910ff2c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 09706910ff2c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 09706910ff2c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 3dbc26e90c59 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/pkg/compress/gzip/gunzip.go View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/compress/gzip/gunzip_test.go View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 17
kortschak
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
6 years, 9 months ago (2013-12-09 21:59:55 UTC) #1
bradfitz
Looks like this still allocates a flate.NewReader each time still? That's pretty big. On Tue, ...
6 years, 9 months ago (2013-12-10 11:55:19 UTC) #2
kortschak
On 2013/12/10 11:55:19, bradfitz wrote: > Looks like this still allocates a flate.NewReader each time ...
6 years, 9 months ago (2013-12-10 20:16:27 UTC) #3
kortschak
On 2013/12/10 20:16:27, kortschak wrote: > If the notion of a Reset were > propagate ...
6 years, 9 months ago (2013-12-13 05:40:18 UTC) #4
bradfitz
Regarding https://codereview.appspot.com/13416045, I'd like to see sync.Pool go in before we add more buffered-chan pools ...
6 years, 9 months ago (2013-12-16 20:29:48 UTC) #5
rsc
i commented on 13416045. reset is better. please do not start adding recycling pools everywhere.
6 years, 9 months ago (2013-12-18 02:42:40 UTC) #6
bradfitz
I think you're missing some context. On Wed, Dec 18, 2013 at 6:42 AM, Russ ...
6 years, 9 months ago (2013-12-18 02:49:24 UTC) #7
rsc
On Tue, Dec 17, 2013 at 9:49 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > I think you're ...
6 years, 9 months ago (2013-12-18 02:59:53 UTC) #8
kortschak
On 2013/12/18 02:42:40, rsc wrote: > i commented on 13416045. reset is better. I agree ...
6 years, 9 months ago (2013-12-18 04:33:43 UTC) #9
bradfitz
On Tue, Dec 17, 2013 at 8:33 PM, <dan.kortschak@adelaide.edu.au> wrote: > On 2013/12/18 02:42:40, rsc ...
6 years, 9 months ago (2013-12-19 02:36:24 UTC) #10
gobot
Replacing golang-dev with golang-codereviews.
6 years, 9 months ago (2013-12-20 16:26:03 UTC) #11
kortschak
On 2013/12/19 02:36:24, bradfitz wrote: > Yeah, either that, or document the concrete type of ...
6 years, 9 months ago (2013-12-20 20:56:18 UTC) #12
gobot
R=rsc@golang.org (assigned by bradfitz@golang.org)
6 years, 8 months ago (2014-01-14 21:32:46 UTC) #13
kortschak
*ping* to get off waiting for author list.
6 years, 7 months ago (2014-02-13 05:47:29 UTC) #14
rsc
it didn't work. i don't know why. the server is seeing your messages. i know ...
6 years, 7 months ago (2014-02-13 06:05:26 UTC) #15
rsc
LGTM There's a typo in the test, which I will fix and submit.
6 years, 5 months ago (2014-04-17 02:43:26 UTC) #16
rsc
6 years, 5 months ago (2014-04-17 02:43:48 UTC) #17
*** Submitted as https://code.google.com/p/go/source/detail?r=3f2fed7c0a19 ***

compress/gzip: add Reset method to Reader

Fixes issue 6364.

LGTM=rsc
R=golang-codereviews, bradfitz, rsc, gobot
CC=golang-codereviews
https://codereview.appspot.com/13512052

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b