code review 13509046: text/template: allow eq to take more than two arguments

text/template: allow eq to take more than two arguments
Based on an old suggestion by rsc, it compares the second
and following arguments to the first.

Unfortunately the code cannot be as pretty as rsc's original
because it doesn't require identical types.

[r, 2013-09-04 03:08:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dsymonds, 2013-09-04 03:10:55]

If you are mentioning that all the logical equations are evaluated, perhaps
also mention how many times the arguments are evaluated too?

[r, 2013-09-04 03:19:47]

That's what I was trying to say. Isn't that what "all the arguments
will be evaluated" says?

[adg, 2013-09-04 03:29:18]

LGTM

Docs are clear to me.

[dsymonds, 2013-09-04 03:30:42]

Is arg1 evaluated once, or N-1 times? It could go either way given that
there's no short-circuiting.

[r, 2013-09-04 03:33:08]

arg1 is evaluated once. It's a function call. I'm not sure why this is
confusing you.

-rob

[dsymonds, 2013-09-04 03:36:51]

You call out that all the args are evaluated and there's no short
circuiting. That's different to normal Go. If I write
  f() == g() || f() == h()
in normal Go then f may be invoked twice.

[r, 2013-09-04 03:42:02]

It's a function call: eq(a, b, c, d). I think it's clear enough.

-rob


On Wed, Sep 4, 2013 at 1:36 PM, David Symonds <dsymonds@golang.org> wrote:
> You call out that all the args are evaluated and there's no short
> circuiting. That's different to normal Go. If I write
>   f() == g() || f() == h()
> in normal Go then f may be invoked twice.

[r, 2013-09-04 03:42:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=3ec3ff3de654 ***

text/template: allow eq to take more than two arguments
Based on an old suggestion by rsc, it compares the second
and following arguments to the first.

Unfortunately the code cannot be as pretty as rsc's original
because it doesn't require identical types.

R=golang-dev, dsymonds, adg
CC=golang-dev
https://codereview.appspot.com/13509046