Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(538)

Issue 13505044: Fix constraints save and add save confirmation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by gary.poster
Modified:
10 years, 8 months ago
Reviewers:
mp+183996, jeff.pihach
Visibility:
Public.

Description

THIS PROTOTYPE BRANCH IS CLOSED; WORK IS BEING LANDED GRADUALLY, ELSEWHERE. Fix constraints save and add save confirmation To QA, deploy a service with the inspector, and then reopen deployed inspector. In configuration and constraints, make changes and click save. The save button should now not change text when you click on it in the constraints tab. The save (and cancel) buttons only appear when there are changes to be saved. The fields correctly recognize when changes are reverted. When changes are saved, the field flashes green to show success. checkboxes do not work properly in this branch: Rick is working on that. The cancel button does not work: that will be a separate branch. For comment and discussion, code and UX. The green flash for fields on save is not as described by UX, but the desired display will be a lot more time consuming--and fragile, I am afraid--than what I have here. I am hoping this is a reasonable compromise. I hope discussion will answer UX issues, as well as resolve what is appropriate for testing. I am a bit too focused on getting this out the door, so need some outside perspective. https://code.launchpad.net/~gary/juju-gui/fixsavetext/+merge/183996 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -15 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/service-configuration.partial View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/service-constraints-viewlet.handlebars View 1 chunk +2 lines, -2 lines 0 comments Download
M app/views/databinding.js View 2 chunks +3 lines, -3 lines 0 comments Download
M app/views/inspector.js View 2 chunks +31 lines, -5 lines 1 comment Download
M lib/views/juju-inspector.less View 5 chunks +72 lines, -4 lines 0 comments Download

Messages

Total messages: 2
gary.poster
Please take a look.
10 years, 8 months ago (2013-09-05 00:45:25 UTC) #1
jeff.pihach
10 years, 8 months ago (2013-09-05 14:12:50 UTC) #2
Looking good but there is some duplication of work, plz see below.

https://codereview.appspot.com/13505044/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/13505044/diff/1/app/views/inspector.js#newcode...
app/views/inspector.js:1047: if (!this.modifiedKeys) {
When a user changes the value of an input the databinding engine keeps track of
these changes via it's _storeChanged method on line 609 of databinding.js. This
method keeps track of these changes in each viewlets _changedvalues method. It
would be nice if you could use this data set instead of trying to keep track of
it yourself. If you need reference to these values in this changed method you
may need to pass it into the method call on line 622.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b