Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(149)

Issue 13501049: code review 13501049: goprotobuf: Make the default default of an enum field i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by dsymonds
Modified:
12 years, 2 months ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

goprotobuf: Make the default default of an enum field be the value of the first enum value, not zero. This makes Go consistent with C++/Java/Python. Fixes issue 43.

Patch Set 1 #

Patch Set 2 : diff -r abcc539d856c https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r abcc539d856c https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r abcc539d856c https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M proto/testdata/test.pb.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M protoc-gen-go/descriptor/descriptor.pb.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M protoc-gen-go/generator/generator.go View 1 1 chunk +21 lines, -0 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.proto View 1 1 chunk +1 line, -1 line 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go View 1 1 chunk +1 line, -1 line 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go.golden View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
12 years, 2 months ago (2013-09-18 00:36:56 UTC) #1
r
LGTM the CL's first line is non-grammatical. s/is/be/ ?
12 years, 2 months ago (2013-09-18 00:57:41 UTC) #2
dsymonds
12 years, 2 months ago (2013-09-18 01:42:42 UTC) #3
*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=6f1bebb865e8 ***

goprotobuf: Make the default default of an enum field be the value of the first
enum value, not zero.

This makes Go consistent with C++/Java/Python.

Fixes issue 43.

R=r
CC=golang-dev
https://codereview.appspot.com/13501049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b