Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2309)

Issue 13500047: code review 13500047: cmd/dist: be more discriminating when determining relea... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by kortschak
Modified:
10 years, 6 months ago
Reviewers:
minux1, adg, rsc
CC:
golang-dev
Visibility:
Public.

Description

cmd/dist: be more discriminating when determining release version

Patch Set 1 #

Patch Set 2 : diff -r 125bf33c1905 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 125bf33c1905 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/cmd/dist/build.c View 1 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 7
kortschak
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 7 months ago (2013-09-21 11:30:27 UTC) #1
minux1
LGTM, but please wait for adg.
10 years, 7 months ago (2013-09-21 20:45:17 UTC) #2
adg
I'm not sure that we want this. There's some good in treating a tagged release ...
10 years, 7 months ago (2013-09-22 23:50:57 UTC) #3
kortschak
No worries. The only reason I proposed was that it would make easier people pointing ...
10 years, 7 months ago (2013-09-22 23:54:52 UTC) #4
kortschak
*** Abandoned ***
10 years, 7 months ago (2013-09-22 23:55:15 UTC) #5
rsc
what andrew did failed for multiple reasons. recognizing the name was just one of them. ...
10 years, 7 months ago (2013-09-23 13:43:30 UTC) #6
kortschak
10 years, 7 months ago (2013-09-23 20:55:23 UTC) #7
Thanks for the clarification.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b