Issue 13479044: code review 13479044: html/template: export the parse.Tree for the escaped te...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13479044: code review 13479044: html/template: export the parse.Tree for the escaped te... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by r

Modified:
11 years, 8 months ago

Reviewers:
MikeSamuel

CC:
MikeSamuel, golang-dev

Visibility:
Public.

Description

html/template: export the parse.Tree for the escaped template The underlying parse tree is visible in text/template, so it should be visible here. Done by copying the underlying *parse.Tree up to the top level of the struct, and then making sure it's kept up to date. Fixes issue 6318.

Patch Set 1 #

Patch Set 2 : diff -r 3ec3ff3de654 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 6828de30a735 https://code.google.com/p/go/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
M	src/pkg/html/template/escape.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/html/template/escape_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/html/template/template.go	View	1	6 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello mikesamuel@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-09-04 06:38:24 UTC) #1

MikeSamuel

LGTM https://codereview.appspot.com/13479044/diff/4001/src/pkg/html/template/template.go File src/pkg/html/template/template.go (right): https://codereview.appspot.com/13479044/diff/4001/src/pkg/html/template/template.go#newcode26 src/pkg/html/template/template.go:26: Tree *parse.Tree gofmt. These lines are indented with ...

11 years, 8 months ago (2013-09-04 14:49:26 UTC) #2

11 years, 8 months ago (2013-09-04 22:23:22 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e9fdda3cdd55 ***

html/template: export the parse.Tree for the escaped template
The underlying parse tree is visible in text/template, so it should be visible
here.
Done by copying the underlying *parse.Tree up to the top level of the struct,
and then making sure it's kept up to date.
Fixes issue 6318.

R=mikesamuel
CC=golang-dev
https://codereview.appspot.com/13479044

Expand All Messages | Collapse All Messages