Issue 13472043: api/uniter: Improve tests readability

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13472043: api/uniter: Improve tests readability (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by dimitern

Modified:
10 years, 7 months ago

Reviewers:
mp+183499, mue

Visibility:
Public.

Description

api/uniter: Improve tests readability Trivial change to rename suite's unit field to stateUnit and the uniter.Unit proxy object received through the API to apiUnit (in each test case), as suggested online. https://code.launchpad.net/~dimitern/juju-core/116-api-uniter-improve-tests/+merge/183499 Requires: https://code.launchpad.net/~dimitern/juju-core/115-api-uniter-fix-result-ok-calls/+merge/183488 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : api/uniter: Improve tests readability #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -124 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/api/uniter/uniter_test.go	View	1	9 chunks	+124 lines, -124 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM, improves differentiation.

Expand All Messages | Collapse All Messages