Issue 13469043: Force inspector boolean config to show as checkbox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13469043: Force inspector boolean config to show as checkbox

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rharding

Modified:
10 years, 7 months ago

Reviewers:
mp+183422, matthew.scott

Visibility:
Public.

Description

Force inspector boolean config to show as checkbox - the service-ghost didn't use the extract service config helper that generated the isBool/isNumeric attributes the template checked. - Add a test and comment to verify this. https://code.launchpad.net/~rharding/juju-gui/boolean-1207870/+merge/183422 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Force inspector boolean config to show as checkbox #

Patch Set 3 : Force inspector boolean config to show as checkbox #

Patch Set 4 : Force inspector boolean config to show as checkbox #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -21 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/service-configuration.partial	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/views/utils.js	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	app/views/viewlets/service-config.js	View	1 chunk	+4 lines, -15 lines	0 comments	Download
M	lib/views/juju-inspector.less	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/test_conflict_ux.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_inspector_settings.js	View	1 chunk	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

10 years, 7 months ago (2013-09-02 13:37:04 UTC) #4

*** Submitted:

Force inspector boolean config to show as checkbox

- the service-ghost didn't use the extract service config helper that
generated the isBool/isNumeric attributes the template checked.
- Add a test and comment to verify this.

R=matthew.scott
CC=
https://codereview.appspot.com/13469043

Expand All Messages | Collapse All Messages